[FIX] account_invoice_tax: avoid including amount_currency when not needed #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rov-adhoc
changed the title
…eeded Fixed an issue in '_get_amount_updated_values' where 'amount_currency' was included in the dictionary even when unnecessary, causing errors when 'amount_company_currency' was set to 'None'. Now, 'amount_currency' is only added if the move's currency differs from the company currency and 'self.amount' is set. This prevents operations involving 'None' values, avoiding errors when processing the data. Reported error: TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'
rov-adhoc
force-pushed
the
18.0-h-90461-rov
branch
from
f4ec44f to
60f54f2
Compare
|
@roboadhoc r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue in '_get_amount_updated_values' where 'amount_currency' was included in the dictionary even when unnecessary, causing errors when 'amount_company_currency' was set to 'None'.
Now, 'amount_currency' is only added if the move's currency differs from the company currency and 'self.amount' is set. This prevents operations involving 'None' values, avoiding errors when processing the data.
Reported error:
TypeError: unsupported operand type(s) for -: 'float' and 'NoneType'