Skip to content

Correct naming in GitLab docs #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

Correct naming in GitLab docs #737

merged 3 commits into from
May 27, 2025

Conversation

drewblas
Copy link
Contributor

No description provided.

@drewblas drewblas requested a review from Copilot May 27, 2025 15:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request corrects naming in the GitLab documentation by updating references from Azure Repos to GitLab.

  • Replaces "Infracost Azure Repos App" with "Infracost GitLab App"
  • Updates merge request diff logic description from Azure DevOps to GitLab
  • Fixes duplication errors in the text
Comments suppressed due to low confidence (1)

docs/integrations/gitlab_app.md:64

  • Duplicate 'with' found in the sentence. Consider removing one 'with' to enhance clarity.
The GitLab App needs access to code repos so it can run the CLI against them, and post merge request comments with with any cost estimates, tagging, and FinOps policy issues.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@drewblas drewblas force-pushed the correct-gitlab-naming branch from d516289 to 5d0c65d Compare May 27, 2025 15:34
@drewblas drewblas requested a review from Copilot May 27, 2025 15:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates naming references in the GitLab integration documentation to ensure consistency with the GitLab App and correct prior mentions of the Azure Repos App.

  • Replace “Azure Repos App” with “GitLab App”
  • Align merge request diff logic wording
  • Minor typo and grammar corrections
Comments suppressed due to low confidence (1)

docs/integrations/gitlab_app.md:64

  • Duplicate 'with' in 'comments with with any cost estimates'. Remove the extra 'with' to correct the typo.
The GitLab App needs access to code repos so it can run the CLI against them, and post merge request comments with with any cost estimates, tagging, and FinOps policy issues. Therefore the bot/user that is installing the GitLab App should have "Maintainer" access to repos; "Developer" and lower does not work as those roles are not authorized to create repo webhooks (that are used to notify Infracost Cloud about new merge requests).

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@drewblas drewblas requested a review from alikhajeh1 May 27, 2025 15:51
@drewblas drewblas merged commit 2a06db8 into master May 27, 2025
4 checks passed
@drewblas drewblas deleted the correct-gitlab-naming branch May 27, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants