Skip to content

Conversation

pelord
Copy link
Member

@pelord pelord commented Apr 7, 2025

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
#1629

What is the new behavior?
#1629
add a widget to workspace to select features by geometry

image

Must be merge and tested after merging this PR infra-geo-ouverte/igo2#1142

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord
Copy link
Member Author

pelord commented Apr 7, 2025

Replacing #1627

@pelord pelord changed the base branch from next to delegate_close_action_widget April 9, 2025 13:59
@alecarn
Copy link
Collaborator

alecarn commented Apr 14, 2025

Même chose ici c'était déjà approuvé dans l'autre PR. Il faudrait s'assurer à l'avenir de ne pas fermer et réouvrir les PR sinon c'est extrêmement difficile a suivre et le code review est une tâche demandante, on ne veut pas le faire en double.

Bref, si tout était beau dans l'autre PR, je m'attends a ce que soit la même chose ici. Alors tu peux merger.

@pelord
Copy link
Member Author

pelord commented Apr 14, 2025

effectivement, fait suite a #1627

@pelord pelord changed the base branch from delegate_close_action_widget to next April 14, 2025 16:49
@pelord pelord force-pushed the interactive-selection-widget_v2 branch from 79f2391 to c60c83c Compare April 14, 2025 18:05
@pelord pelord merged commit c7c82a9 into next Apr 15, 2025
3 checks passed
@pelord pelord deleted the interactive-selection-widget_v2 branch April 15, 2025 17:44
@alecarn
Copy link
Collaborator

alecarn commented Apr 15, 2025

🎉 This PR is included in version 19.0.0-next.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alecarn
Copy link
Collaborator

alecarn commented Oct 2, 2025

🎉 This PR is included in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants