-
Notifications
You must be signed in to change notification settings - Fork 30
feat(code): Implement minimal gossip properties to ensure liveness #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
111f5d5
Add gossip messages and handling
ancazamfir 5a2068b
Add the new gossip and msg handling files
ancazamfir a99974d
Add serialization test for round certificate
ancazamfir 4c9c24a
Send gossip messages over /gossip channel
ancazamfir d958ebf
Reuse exsiting encode and decode vote type functions
ancazamfir fb63cf9
Update version and breaking changes
ancazamfir b1c9f40
Store the round certificate when new round condition occurs
ancazamfir f7c82f0
On hidden lock suspicion (round > x), restream also the proposal
ancazamfir 1f5dfbc
Add vote by vote verification for round certificate
ancazamfir 6f6b7b6
Merge branch 'main' into anca/gossip
romac 3ecff01
Fix standalone build, less cloning
romac 0b21113
Less cloning
romac a071616
Rebroadcast the round certificate
ancazamfir 4ad2725
Fix clippy
ancazamfir fdab84c
Add `RebroadcastRoundCertificate` event
romac 92cf8dd
Move middlewares in their own module
romac eb5f1ed
Add round and vote type to `expect_vote_rebroadcast`
romac 058385f
Show log when `on_event` step fails
romac b14cf9d
Add basic test for vote and round certificate rebroadcast
romac 22f456c
Update comments in test
romac 2526b2c
Rename gossip to liveness
ancazamfir b2a6e35
Rename gossip to liveness
ancazamfir 039dd37
For hidden lock rebroadcast the proposal message also.
ancazamfir 3db290c
Apply suggestions from code review
ancazamfir 53170da
Correct comments
ancazamfir e1a17ba
Rebroadcast proposal and polka for HIDDEN_LOCK_ROUND also
ancazamfir 7e3c65e
Apply suggestions from code review
ancazamfir 16ccd0d
Fix formatting
ancazamfir 1c457d7
Add comments to liveness message processing
ancazamfir 1f39c4d
Fix spelling
ancazamfir e3ade2f
Panic when certificates are not found suggesting internal errors
ancazamfir 3f4305c
Merge branch 'main' into anca/gossip
ancazamfir 03ae78f
Add test for hidden lock
ancazamfir 211ba01
Fix reuse of RestreamProposal with nil valid round for hidden lock
ancazamfir 28b17e1
chore(code): Send rebroadcast votes to the liveness topic (#1012)
ancazamfir 8e9cba6
Re-use `HIDDEN_LOCK_ROUND` constant from liveness test
romac 2a330c3
Update BREAKING_CHANGES.md
ancazamfir 8628753
Cleanup debugs and consensus traces
ancazamfir 0d7321e
Enable the rebroadcast wal tests
ancazamfir f7bd600
Merge branch 'main' into anca/gossip
ancazamfir f5926ec
Disable again the rebroadcast mode tests
ancazamfir 6f2c5a5
Use a single rebroadcast timer
ancazamfir e2127c8
Try fix for round_certificate_rebroadcast test
ancazamfir f8324b8
Merge branch 'main' into anca/gossip
ancazamfir 265ad5e
Store the enter_round with the certificate, check it matches current
ancazamfir 35b4604
Check in test broadcast of round certificate only, no rebroadcast
ancazamfir 5ca73e4
feat(code): Implement Solution 2 for the RoundSync (#1032)
ancazamfir 3f5cba6
Apply suggestions from code review
ancazamfir fae6219
Apply suggestions from code review
ancazamfir a1dd443
Apply suggestions from code review
ancazamfir e0c3353
Update comments
ancazamfir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.