chore(test): Replay WAL before start round

[ancazamfir]

Closes: #XXX

An experiment for simply moving the WAL replay before start round. If we enter new round with a proposal already we should not getValue() again.
We should also find all the votes already stored for all rounds, etc. NewRound mux would need more updates though.
edit: it's actually step_change mux and it looks pretty complete.

---

PR author checklist

For all contributors

• Reference GitHub issue
• Ensure PR title follows the conventional commits spec

For external contributors

• Maintainers of Malachite are allowed to push changes to the branch

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d4bd49d) to head (a47e139).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@     Coverage Diff     @@
##   main   #898   +/-   ##
===========================
===========================

Components	Coverage Δ
core	∅ <ø> (∅)
engine	∅ <ø> (∅)
app	∅ <ø> (∅)
starknet	∅ <ø> (∅)

[ancazamfir]

So it looks like one thing missing in step change mux, specifically for this case Unstarted -> Propose, is looking for conditions at higher rounds (L49 and L55). We should add multiple round wal tests.

[romac]

@ancazamfir I added a new PrepareHeight input to avoid mutating the driver state from outside of the core-consensus crate, what do you think?

[ancazamfir]

I think that some issues that may occur with this PR approach are related to the timeouts. In particular if the timeout has been writtedn to wal but its effects (e.g. voting nil) has not before the restart, then after restart we will run the timers. This is because the timeouts in Unstarted step (with the exception of TimeoutPrecommit) have no effect.
We should understand how to handle this. Not sure if writing StartRound to wal would help.

Also we need to add wal tests that include timeouts (if we don't have already).

[romac]

As discussed today, let's close this in favor of #896

[ancazamfir]

@romac just to clarify, we will still replay (proposals) at start height before start round, meaning most of the changes here should still apply, right?

[romac]

Yes, but since the other PR contains most of the changes already I will move what's needed from here to there.