Skip to content

Enable opening Google Images tab #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable opening Google Images tab #634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3a8c83
Enable opening Google Images tab
tdksk Sep 27, 2024
2d0a819
Enable opening other tabs in Google Images page
tdksk Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions src/search_engines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ class GoogleSearch {

static #isImagesTab() {
const searchParams = new URLSearchParams(window.location.search);
return searchParams.get('tbm') === 'isch';
return searchParams.get('udm') === '2';
}

static #getImagesTabResults() {
Expand Down Expand Up @@ -553,7 +553,9 @@ class GoogleSearch {
}

static #imageSearchTabs() {
const visibleTabs = document.querySelectorAll('.T47uwc > a');
const visibleTabs = document.querySelectorAll(
'.crJ18e div[role="listitem"] > a',
);
// NOTE: The order of the tabs after the first two is dependent on the
// query. For example:
// - "cats": videos, news, maps
Expand All @@ -562,21 +564,25 @@ class GoogleSearch {
return {
navigateSearchTab: visibleTabs[0],
navigateMapsTab: selectorElementGetter(
'.T47uwc > a[href*="maps.google."]',
'.crJ18e div[role="listitem"] > a[href*="maps.google."]',
),
navigateVideosTab: selectorElementGetter(
'.crJ18e div[role="listitem"] > a[href*="&tbm=vid"]',
),
navigateNewsTab: selectorElementGetter(
'.crJ18e div[role="listitem"] > a[href*="&tbm=nws"]',
),
navigateVideosTab: selectorElementGetter('.T47uwc > a[href*="&tbm=vid"]'),
navigateNewsTab: selectorElementGetter('.T47uwc > a[href*="&tbm=nws"]'),
navigateShoppingTab: selectorElementGetter(
'a[role="menuitem"][href*="&tbm=shop"]',
'a[role="link"][href*="&tbm=shop"]',
),
navigateBooksTab: selectorElementGetter(
'a[role="menuitem"][href*="&tbm=bks"]',
'a[role="link"][href*="&tbm=bks"]',
),
navigateFlightsTab: selectorElementGetter(
'a[role="menuitem"][href*="&tbm=flm"]',
'a[role="link"][href*="&tbm=flm"]',
),
navigateFinancialTab: selectorElementGetter(
'a[role="menuitem"][href*="/finance?"]',
'a[role="link"][href*="/finance?"]',
),
// TODO: Disable image search's default keybindings to avoid confusing the
// user, because the default keybindings can cause an indenepdent
Expand Down Expand Up @@ -618,7 +624,7 @@ class GoogleSearch {
// eslint-disable-next-line max-len
'a[href*="/search?q="]:not([href*="&tbm="]):not([href*="maps.google."])',
),
navigateImagesTab: selectorElementGetter('a[href*="&tbm=isch"]'),
navigateImagesTab: selectorElementGetter('a[href*="&udm=2"]'),
navigateVideosTab: selectorElementGetter('a[href*="&tbm=vid"]'),
navigateMapsTab: selectorElementGetter('a[href*="maps.google."]'),
navigateNewsTab: selectorElementGetter('a[href*="&tbm=nws"]'),
Expand Down