Skip to content

feat: allow passing git hash via environment variable in build.rs #26618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

pfactum
Copy link
Contributor

@pfactum pfactum commented Jul 18, 2025

This allows building a package from a release tarball without invoking git.

Closes #25266

Describe your proposed changes here.

  • I've read the contributing section of the project README.
  • Signed CLA (if not already signed).

@hiltontj hiltontj changed the title build.rs: allow passing git hash via environment variable feat: allow passing git hash via environment variable in build.rs Jul 18, 2025
@hiltontj
Copy link
Contributor

@pfactum - we have a semantic commit message rule that requires the use of conventional commit messages.

Could you please change the commit message to have the structure:

feat: <message>

You could use the title of the PR, which I edited.

This allows building from a release tarball without invoking git.

Closes: influxdata#25266
Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
@pfactum
Copy link
Contributor Author

pfactum commented Jul 21, 2025

Sure, pushed with a new title.

@mgattozzi mgattozzi merged commit e9d4f6c into influxdata:main Jul 28, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistencies build.rs and git hash handling
3 participants