-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Fix mcp server startup failure #7329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mcp server startup failure #7329
Conversation
fix mcp server can not auto start or upgrade
CI failed
|
[tests / ragflow_tests need chmod +X docker/entrypoint.sh
file docker/entrypoint.sh need chmod +X ,then test again ~ |
add docker/entrypoint.sh exec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chmod + x for docker/entrypoint.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I said that - ./entrypoint.sh:/ragflow/entrypoint.sh
is not necessary because every time we build the image (via the Dockerfile), the entrypoint script is automatically handled. However, adding this line to docker-compose.yml does exactly enhance the flexibility, as we no longer need to rebuild the image every time if we only modify some arguments. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
I don't quite follow. Why do we need to mount |
because file in docker not work can not start mcp server correctly as I say at pr start so need fixed it
发自我的iPhone
…------------------ Original ------------------
From: Kevin Hu ***@***.***>
Date: Sun,Apr 27,2025 0:05 PM
To: infiniflow/ragflow ***@***.***>
Cc: yiminghub2024 ***@***.***>, Author ***@***.***>
Subject: Re: [infiniflow/ragflow] Fix mcp server startup failure (PR #7329)
Reopened #7329.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Not empty , it’s same file with main only add chime +X to it
发自我的iPhone
…------------------ Original ------------------
From: Kevin Hu ***@***.***>
Date: Sun,Apr 27,2025 0:05 PM
To: infiniflow/ragflow ***@***.***>
Cc: yiminghub2024 ***@***.***>, Author ***@***.***>
Subject: Re: [infiniflow/ragflow] Fix mcp server startup failure (PR #7329)
Reopened #7329.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
What problem does this PR solve?
0.18.0 mcp server can not start with upgrade from 0.17.2 or new install except rebuild all docker
Close #7321
mcp server can not start auto from docker :
2025-04-25 17:30:44,512 INFO 25 task_executor_2a9f3e2de99a_0 reported heartbeat: {"name": "task_executor_2a9f3e2de99a_0", "now": "2025-04-25T17:30:44.509+08:00", "boot_at": "2025-04-25T16:43:33.038+08:00", "pending": 0, "lag": 0, "done": 0, "failed": 0, "current": {}}
usage: server.py [-h] [--base_url BASE_URL] [--host HOST] [--port PORT]
[--mode MODE] [--api_key API_KEY]
server.py: error: unrecognized arguments:
problem:
server.py in docker start arguments not correct , so mcp server start fail
reason:
Type of change