Skip to content

Fix: resolve issue where Categorize and Concentrator components failed to pass upstream inputs downstream #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sci-fiBrain
Copy link
Contributor

What problem does this PR solve?

resolve issue where Categorize and Concentrator components failed to pass upstream inputs downstream

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working, pull request that fix bug. labels Apr 5, 2025
@KevinHuSh
Copy link
Collaborator

Every component could assign the inputs which are output of other components.

@Sci-fiBrain
Copy link
Contributor Author

Sci-fiBrain commented Apr 7, 2025

Manually input each component of the Settings can be difficult, especially if the graphics are complex. In addition, manual input parameters of Settings will be inaccurate input problems. I fixed and perfected the get _ input method, The sections dealing with categorize and concentrator are not complete (just continue), I call it recursively to get the output of the correct upstream component.

@yingfeng yingfeng added the ci Continue Integration label Apr 7, 2025
@Sci-fiBrain
Copy link
Contributor Author

@KevinHuSh Could merge this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working, pull request that fix bug. ci Continue Integration size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants