Skip to content

fix: inject config when use oss #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pj1987111
Copy link

@pj1987111 pj1987111 commented Mar 25, 2025

What problem does this PR solve?

When enabling OSS configuration, the configuration fails to load because the script's first character is #. This issue can be resolved by modifying the configuration file through volume injection/mounting.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@KevinHuSh
Copy link
Collaborator

KevinHuSh commented Mar 26, 2025

I did not quite follow. service_conf.yaml.template had already copy to docker image while building. Why's that necessary ?

@pj1987111
Copy link
Author

I did not quite follow. service_conf.yaml.template had already copy to docker image while building. Why's that necessary ?

image
The OSS configurations and subsequent settings in the image files are commented out (prefixed with #), resulting in the rendered configurations also being commented. To make them effective, rebuilding the image would be required, which is time-consuming. Therefore, it's more efficient to mount the configuration files via volumes instead of embedding them in the image.

@pj1987111
Copy link
Author

issue related in
#6522

@KevinHuSh KevinHuSh added size:S This PR changes 10-29 lines, ignoring generated files. ☯️ refactor Pull request that refactor/refine code labels Mar 26, 2025
@lewisliuyi
Copy link

mark

@KevinHuSh
Copy link
Collaborator

Appreciations!
By our evaluations, this feature is not going to be mereged into main branch.

@KevinHuSh KevinHuSh closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☯️ refactor Pull request that refactor/refine code size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants