Skip to content

Conversation

Big-Smarty
Copy link
Collaborator

Added controller support.
Abstracted input by adding the Input class, overarching both KeyboardMouseInputData and the also newly added GamepadInputData.

@IAmNotHanni IAmNotHanni self-requested a review December 29, 2022 18:10
@IAmNotHanni IAmNotHanni added the feat:input keybord/mouse input label Dec 29, 2022
@IAmNotHanni
Copy link
Member

Nice work! I think I will buy myself a controller just to check if it's working. Will review later

Copy link
Member

@IceflowRE IceflowRE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IceflowRE
Copy link
Member

Other things:
Can you rename the commits that they match our naming convention? See the Github Actions.
Ignore the failed building for now, it is broken, will see when i get time for that.

This will only support one Gamepad right? not multiple?

@IAmNotHanni
Copy link
Member

@IceflowRE About multiple gamepads/joysticks: I just ordered several online. We should do it in another pull request pls.

@IAmNotHanni
Copy link
Member

IAmNotHanni commented Dec 30, 2022

  • Update docs

https://inexor-vulkan-renderer.readthedocs.io/en/latest/development/reference/keyboard-mouse-input.html
The reference page about input in the docs states:

Inexor does not support joysticks yet.

That's no longer true. Also, the ref pages needs to be renamed to "keyboard, mouse and joystick input"
Furthermore, the docs about keyboard and mouse are now outdated as well.
I will take care of this. I will push into this pull request then.

Copy link
Member

@yeetari yeetari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, code looks good, please could you squash the commits though.

@IAmNotHanni IAmNotHanni added the cat:enhancement enhancement/requested feature/update of existing features label May 20, 2023
@IAmNotHanni IAmNotHanni marked this pull request as draft October 7, 2025 20:05
@Big-Smarty Big-Smarty marked this pull request as ready for review October 14, 2025 13:57
@IAmNotHanni
Copy link
Member

Other things: Can you rename the commits that they match our naming convention? See the Github Actions. Ignore the failed building for now, it is broken, will see when i get time for that.

This will only support one Gamepad right? not multiple?

Yeah we will require further rounds of revision.

Copy link
Member

@IAmNotHanni IAmNotHanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@IAmNotHanni IAmNotHanni changed the title [input] Added controller support [input] Add gamepad support Oct 14, 2025
@IAmNotHanni
Copy link
Member

I still need to update the docs on input, will do this tomorrow.

@IAmNotHanni IAmNotHanni merged commit bbb3bb6 into inexorgame:main Oct 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:enhancement enhancement/requested feature/update of existing features feat:input keybord/mouse input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants