-
Notifications
You must be signed in to change notification settings - Fork 41
[input] Add gamepad support #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice work! I think I will buy myself a controller just to check if it's working. Will review later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Other things: This will only support one Gamepad right? not multiple? |
@IceflowRE About multiple gamepads/joysticks: I just ordered several online. We should do it in another pull request pls. |
https://inexor-vulkan-renderer.readthedocs.io/en/latest/development/reference/keyboard-mouse-input.html
That's no longer true. Also, the ref pages needs to be renamed to "keyboard, mouse and joystick input" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, code looks good, please could you squash the commits though.
Yeah we will require further rounds of revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I still need to update the docs on input, will do this tomorrow. |
Added controller support.
Abstracted input by adding the Input class, overarching both KeyboardMouseInputData and the also newly added GamepadInputData.