[2.x] Support SSR in Vite dev mode #673
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalbaljet
changed the title
|
Thanks for this! I've refactored it a bit and added tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel part of inertiajs/inertia#2014.
If user doesn't configure SSR in Vite, the
[vite]/renderendpoint will return 404. In that case, the response is ignored and Inertia proceeds without SSR, so this change should be backwards compatible. It slows the request down a bit, but this happens only in dev (whenlaravel-vite-plugin's hotfile is present), and only on inital request (consecutive ones aren't SSR-ed anyway) so I think it's acceptable.I will add tests after the initial idea is approved by maintainers.