v3.1.5: Fix #75 #76
Merged
v3.1.5: Fix #75 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature scoping
JodiWarren
commented
May 29, 2025
| @@ -112,7 +112,7 @@ export const setup = (build, _options) => { | |||
| const rpath = relative(buildRoot, path); | |||
| const prefix = basename(rpath, extname(path)) | |||
| .replace(/[^a-zA-Z0-9]/g, '-') | |||
| .replace(/^\-*/, ''); | |||
| .replace(/^-*/, ''); | |||
There was a problem hiding this comment.
Just removing an extraneous escape character
JodiWarren
commented
May 29, 2025
Comment on lines
+324
to
+325
| const cssOutputsMap = Object.entries(r.metafile?.outputs ?? {}) | ||
| .reduce(/** @type {(m: Record<string, string>, o: any) => Record<string, string>} */(m, [o, {inputs}]) => { |
There was a problem hiding this comment.
Removing a typescript failure due to it not understanding the type of the accumulator. There could be a better solution to be quite honest.
JodiWarren
commented
May 29, 2025
Comment on lines
+7
to
+9
| animation: 3s linear slide-in; | ||
| display: grid; | ||
| grid-template: "image text"; |
There was a problem hiding this comment.
To test the hashing/not-hashing of the feature scoping controls.
JodiWarren
commented
May 29, 2025
| @@ -19,7 +19,8 @@ import cssModulesPlugin from '../index.js'; | |||
| plugins: [ | |||
| cssModulesPlugin({ | |||
| inject: '#my-custom-element-with-shadow-dom', | |||
| emitDeclarationFile: true | |||
| emitDeclarationFile: true, | |||
| pattern: "__[hash]_[local]" | |||
There was a problem hiding this comment.
LightningCSS complains if the pattern doesn't end with [local] when grid areas are being used. See: https://lightningcss.dev/css-modules.html#css-grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature scoping control: https://lightningcss.dev/css-modules.html#turning-off-feature-scoping
Fixes #75