[WIP, M141] Vertical tabs

patches/helium/ui/vertical-tabs/tab-container.patch

@@ -147,7 +147,7 @@
    // During animations, our preferred width tightly hugs the current bounds of
    // our children.
    std::optional<int> preferred_width = GetMidAnimationTrailingX();
-@@ -1216,6 +1278,22 @@ void TabContainerImpl::AnimateScrollToSh
+@@ -1216,6 +1278,21 @@ void TabContainerImpl::AnimateScrollToSh
    tab_scrolling_animation_->Start();
  }
 
@@ -157,7 +157,6 @@
 +    tab_scrolling_animation_->Stop();
 +  }
 +
-+
 +  gfx::Rect start_rect(0, start_edge, 0, 0);
 +  gfx::Rect target_rect(0, target_edge, 0, 0);
 +
@@ -170,7 +169,7 @@
  void TabContainerImpl::AnimateTabSlotViewTo(TabSlotView* tab_slot_view,
                                              const gfx::Rect& target_bounds) {
    // If we don't own the tab, let our controller handle it.
-@@ -1285,23 +1363,42 @@ void TabContainerImpl::StartInsertTabAni
+@@ -1285,23 +1362,42 @@ void TabContainerImpl::StartInsertTabAni
    gfx::Rect bounds = GetTabAtModelIndex(model_index)->bounds();
    bounds.set_height(GetLayoutConstant(TAB_STRIP_HEIGHT));
 
@@ -219,7 +218,7 @@
    GetTabAtModelIndex(model_index)->SetBoundsRect(bounds);
 
    // Animate in to the full width.
-@@ -1315,7 +1412,9 @@ void TabContainerImpl::StartRemoveTabAni
+@@ -1315,7 +1411,9 @@ void TabContainerImpl::StartRemoveTabAni
    UpdateIdealBounds();
    if (in_tab_close_ && GetTabCount() > 0 &&
        override_available_width_for_tabs_ >
@@ -230,7 +229,7 @@
      // Tab closing mode is no longer constraining tab widths - they're at full
      // size. Exit tab closing mode so that it doesn't artificially inflate our
      // bounds.
-@@ -1365,17 +1464,21 @@ gfx::Rect TabContainerImpl::GetTargetBou
+@@ -1365,17 +1463,21 @@ gfx::Rect TabContainerImpl::GetTargetBou
 
    // Compute the target bounds for animating this tab closed.  The tab's left
    // edge should stay joined to the right edge of the previous tab, if any.
@@ -262,7 +261,7 @@
 
    return target_bounds;
  }
-@@ -1650,7 +1753,8 @@ bool TabContainerImpl::ShouldTabBeVisibl
+@@ -1650,7 +1752,8 @@ bool TabContainerImpl::ShouldTabBeVisibl
    // N.B. This is separate from the tab being potentially scrolled offscreen -
    // this solely determines whether the tab should be clipped for the
    // pre-scrolling overflow behavior.
@@ -272,7 +271,7 @@
      return true;
    }
 
-@@ -1819,4 +1923,5 @@ bool TabContainerImpl::IsValidModelIndex
+@@ -1819,4 +1922,5 @@ bool TabContainerImpl::IsValidModelIndex
 
  BEGIN_METADATA(TabContainerImpl)
  ADD_READONLY_PROPERTY_METADATA(int, AvailableWidthForTabContainer)

patches/helium/ui/vertical-tabs/tab-strip.patch

@@ -707,7 +707,7 @@
  #include "chrome/browser/ui/views/tabs/tab_strip.h"
  #include "chrome/browser/ui/views/tabs/tab_strip_controller.h"
  #include "chrome/browser/ui/views/tabs/tab_strip_scrolling_overflow_indicator_strategy.h"
-@@ -105,15 +106,25 @@ TabStripScrollContainer::TabStripScrollC
+@@ -105,15 +106,27 @@ TabStripScrollContainer::TabStripScrollC
    tab_strip->SetAvailableWidthCallback(
        base::BindRepeating(&TabStripScrollContainer::GetTabStripAvailableWidth,
                            base::Unretained(this)));
@@ -727,6 +727,8 @@
 +  if (tabs::AreHeliumVerticalTabsEnabled()) {
 +    scroll_view->SetVerticalScrollBarMode(
 +      views::ScrollView::ScrollBarMode::kEnabled);
++    scroll_view->SetHorizontalScrollBarMode(
++        views::ScrollView::ScrollBarMode::kDisabled);
 +  } else {
 +    scroll_view->SetHorizontalScrollBarMode(
 +        views::ScrollView::ScrollBarMode::kHiddenButEnabled);
@@ -736,16 +738,17 @@
    scroll_view->SetContents(std::move(tab_strip));
 
    overflow_indicator_strategy_ =
-@@ -134,7 +145,7 @@ TabStripScrollContainer::TabStripScrollC
+@@ -134,7 +147,8 @@ TabStripScrollContainer::TabStripScrollC
        base::BindRepeating(&TabStripScrollContainer::OnContentsScrolledCallback,
                            base::Unretained(this)));
 
 -  if (!base::FeatureList::IsEnabled(features::kTabScrollingButtonPosition)) {
-+  if (!base::FeatureList::IsEnabled(features::kTabScrollingButtonPosition) || tabs::AreHeliumVerticalTabsEnabled()) {
++  if (!base::FeatureList::IsEnabled(features::kTabScrollingButtonPosition) ||
++      tabs::AreHeliumVerticalTabsEnabled()) {
      leading_scroll_button_ = nullptr;
      trailing_scroll_button_ = nullptr;
      overflow_view_ = AddChildView(
-@@ -235,6 +246,10 @@ int TabStripScrollContainer::GetTabStrip
+@@ -235,6 +249,10 @@ int TabStripScrollContainer::GetTabStrip
    return overflow_view_->GetAvailableSize(scroll_view_).width().value();
  }