-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[New] order
: add caseInsensitive: 'invert'
option
#1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
forivall
wants to merge
2
commits into
import-js:main
Choose a base branch
from
forivall:feat/case-sort-invert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bikeshed: maybe in addition to true/false, we could support (and recommend) a three-option string enum? iow, this can be
'ignore' | 'upperFirst' | 'lowerFirst'
, withfalse
being an alias forignore
andtrue
being an alias forupperFirst
?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, perhaps the "caseInsensitive" should be deprecated and make the 3 option string enum under an option called "caseSensitive" or "caseSensitivity"?i wonder what other things call their options?
sort
calls its option--ignore-case
/-f
(the f is for "fold lower case to upper case" - maybe too obscure of a term to use here)str.casefold()
, algorithm defined in unicode spec)Intl.locale.caseFirst
andsensitivity
(under options)regExp.ignoreCase
sort-type-union-intersection-members
(non-configurable)sort-vars
hasignoreCase
sort-vars
andsort-imports
haveignoreCase
sort-keys
hascaseSensitive
andnatural
With that all said, i'd like to suggest keeping
caseInsensitive
as a boolean, and for this option, introducecaseFirst: 'upper' | 'lower'
, based on theIntl.Collator
optionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably also be a good idea to just use
Intl.Collator
like what typescript-eslint does instead of doing the case-munging manuallyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternative diff, using
caseFirst
is here: master...forivall:feat/case-first