Skip to content

Laravel 12.x Compatibility #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laravel-shift
Copy link
Contributor

@laravel-shift laravel-shift commented Feb 16, 2025

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 12.x.

Before merging, you need to:

  • Checkout the l12-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

Summary by CodeRabbit

  • Chores
    • Updated dependency requirements to support newer versions of key frameworks, allowing compatibility with Laravel 12 and the latest testing environment. These improvements ensure that your installation stays in sync with the most recent releases and benefits from enhanced integration with modern tooling.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected a dependency for the laravel/framework. Unless you have a special requirement for depending on the entire Laravel framework, it's recommended to add dependencies for the specific illuminate packages instead.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-MasterPass.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "imanghafoori/laravel-masterpass": "dev-l12-compatibility",
    }
}

Finally, run: composer update

Copy link

coderabbitai bot commented Feb 16, 2025

Walkthrough

The composer.json file has been updated to extend dependency support. The version constraint for the laravel/framework dependency now includes Laravel version 12, and the orchestra/testbench dependency now supports version 10. These modifications adjust the allowed version ranges in both the require and require-dev sections.

Changes

File Summary
composer.json Updated laravel/framework version constraint to include ^12.0 and orchestra/testbench to include ^10.0.

Poem

I’m a bunny with a keen eye for code,
Hopping through constraints along the road.
Laravel now leaps to version twelve,
Testbench bounds now twelve, too—oh well!
With whiskers twitching and paws so light,
I celebrate these changes day and night!
🐇💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
composer.json (1)

21-23: Update laravel/framework Dependency for Laravel 12.x Compatibility

The version constraint for laravel/framework now includes ^12.0, which ensures compatibility with Laravel 12.x. Please verify that all package features work as expected with Laravel 12. Additionally, consider whether you truly need the entire framework as a dependency. If your package only utilizes specific components, switching to individual illuminate/* packages might reduce dependency bloat.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32608fb and 341cb05.

📒 Files selected for processing (1)
  • composer.json (2 hunks)
🔇 Additional comments (1)
composer.json (1)

33-34: Update orchestra/testbench Dependency for Version 10 Support

The version constraint for orchestra/testbench now includes ^10.0 to support the latest testbench release. Ensure that your test suite is fully compatible with version 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant