Skip to content

Conversation

@alikhavarii13
Copy link
Contributor

@alikhavarii13 alikhavarii13 commented Apr 10, 2025

Screenshot (4)

added text and text style for barchart in rodstackitem you can see it in sample 4 and 5

Fixes #598

@imaNNeo
Copy link
Owner

imaNNeo commented Apr 28, 2025

Hi Ali,
Thanks for contributing!
But there are some points to mention, please take a look:

@alikhavarii13
Copy link
Contributor Author

Thanks a lot for your feedback. I fixed all problems that you mentioned

@imaNNeo
Copy link
Owner

imaNNeo commented May 3, 2025

Perfect!
Now I just see a conflict. Please rebase your branch and resolve it (It's about the code docs, as I see)

Also, please update the documentation in our bar_chart.md (as it is explained in our contribution guideline)

And the last thing. Please revert the changes on sample 4
image

But let's keep it in sample 5 with a minor change,
You can show the section if it is touched.
And we can have A, B, C, and D as they make more sense
(For your convenience, I provided this gist code for the sample5, I think you can just copy-paste)

CleanShot.2025-05-03.at.23.43.45.mp4

@alikhavarii13
Copy link
Contributor Author

Thanks again. I fixed the problems. Is there anything else to fix ?

@imaNNeo
Copy link
Owner

imaNNeo commented May 9, 2025

Perfect!
Everything is good. Please rebase the branch, then I can merge it into the main.
Thanks Ali!

@alikhavarii13
Copy link
Contributor Author

I am really sorry. I had never used rebase I searched and did some work, but I don't know if it is fixed or not

@alikhavarii13 alikhavarii13 changed the title add label inside bar chart add label inside bar chart Fixes #598 Jul 1, 2025
@alikhavarii13 alikhavarii13 changed the title add label inside bar chart Fixes #598 add label inside bar chart Jul 1, 2025
@imaNNeo
Copy link
Owner

imaNNeo commented Aug 1, 2025

Hi, can you please rebase your branch? There are some conflicts.
Please keep in mind that you don't have to touch CHANGELOG.md, example/pubspec.yaml and pubspec.yaml
I will manage those changes, just keep them unchanged please

@alikhavarii13 alikhavarii13 force-pushed the feature/add-label-bar-chart branch from 688daf5 to 899c2e8 Compare August 12, 2025 17:49
@alikhavarii13
Copy link
Contributor Author

it's done.

@ad-angelo
Copy link

Hi,
Thanks for the PR !
I've noticed that the label is upside-down with rotationQuarterTurns to 1 or 3.
image

@alikhavarii13
Copy link
Contributor Author

Hi, Thanks for the PR ! I've noticed that the label is upside-down with rotationQuarterTurns to 1 or 3. image

Hi, can you please send me your code here

@imaNNeo
Copy link
Owner

imaNNeo commented Aug 21, 2025

And after that comment, it's approved and ready to get merged!
I'm sorry it took a long time.
I appreciate your contribution, Ali!

@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.48%. Comparing base (9e51b11) to head (d98c888).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
+ Coverage   92.44%   92.48%   +0.03%     
==========================================
  Files          50       50              
  Lines        3681     3700      +19     
==========================================
+ Hits         3403     3422      +19     
  Misses        278      278              
Flag Coverage Δ
flutter 92.48% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imaNNeo
Copy link
Owner

imaNNeo commented Aug 21, 2025

There's a code verification issue
I think you need to do a rebase to get rid of that.

@alikhavarii13 alikhavarii13 force-pushed the feature/add-label-bar-chart branch from 98a1f1c to db9fee9 Compare August 21, 2025 12:40
@imaNNeo
Copy link
Owner

imaNNeo commented Aug 21, 2025

It seems the test coverage has dropped.
You should write unit test for all the new parts

@alikhavarii13
Copy link
Contributor Author

I added unit test

@imaNNeo imaNNeo merged commit b3ce63a into imaNNeo:main Aug 24, 2025
4 checks passed
@imaNNeo
Copy link
Owner

imaNNeo commented Aug 24, 2025

Perfect!
Thanks for your nice contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Text Inside Bar to Bar Chart

3 participants