- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.9k
add label inside bar chart #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add label inside bar chart #1893
Conversation
| Hi Ali, | 
| Thanks a lot for your feedback. I fixed all problems that you mentioned | 
| Perfect! Also, please update the documentation in our bar_chart.md (as it is explained in our contribution guideline) And the last thing. Please revert the changes on sample 4 But let's keep it in sample 5 with a minor change, CleanShot.2025-05-03.at.23.43.45.mp4 | 
| Thanks again. I fixed the problems. Is there anything else to fix ? | 
| Perfect! | 
| I am really sorry. I had never used rebase I searched and did some work, but I don't know if it is fixed or not | 
| Hi, can you please rebase your branch? There are some conflicts. | 
688daf5    to
    899c2e8      
    Compare
  
    | it's done. | 
| And after that comment, it's approved and ready to get merged! | 
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
+ Coverage   92.44%   92.48%   +0.03%     
==========================================
  Files          50       50              
  Lines        3681     3700      +19     
==========================================
+ Hits         3403     3422      +19     
  Misses        278      278              
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| There's a code verification issue | 
98a1f1c    to
    db9fee9      
    Compare
  
    | It seems the test coverage has dropped. | 
| I added unit test | 
| Perfect! | 



added text and text style for barchart in rodstackitem you can see it in sample 4 and 5
Fixes #598