adding small delay in creating publisher #57
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! Is there perhaps a better way to wait for the publisher to be ready? The 200ms seems arbitrary. Maybe there is a dedicated function/attribute of the publisher. |
|
If its problematic for the first message to be missed, perhaps a better roption is to support explicitly setting the QoS? |
|
I believe that this #61 makes this unnecessary if you are willing to configure the types explicitly |
|
These changes should be made obsolete by #61, thank you very much, anyway! Hopefully your problem is resolved now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small delay is added in the 'mqtt2primitive' function because whenever the first message is received, it creates a publisher. Since there is no delay in creating a publisher and publishing a message, the first message is always missed on the ROS topic. Adding a delay in creating the publisher solved the problem.