feat: database-backed artifact blob storage #8992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial revert of 5d6bd49
Make async commit optional so that celery tasks don't spawn other celery tasks. This is a definite fix. Reverses order of StoredObject.create() and storage.save(). This avoids a race condition between an async commit and the creation of a StoredObject, but need to review whether this introduces other problems.
fix: dont test for v1 apis into the blobdb app models
Use blob modified timestamp as mtime in replicated metadata. This is the intended behavior and matches BlobdbStorage.
chore: merge main into feat/blobstage
* chore(dev): remove assert I like the idea, but settings are sometimes loaded more than once so this approach doesn't work * chore: blobdb migrations in k8s * chore: fix typo in commet * chore: add replicator pod for k8s deploy * chore: drop unnecessary ports from celery/beat * chore: fix tyop * chore: settings for blobdb / replication * chore: put quotes back around $@
* refactor: minor refactor + ruff style * chore: additional logging
* fix: use correct DB for transaction * chore: stale comment
rjsparks
approved these changes
Jun 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.