feat: more flexible liaison stmt "From Contact" #8958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to go |
from_name and to_name were removed in 2015!
rjsparks
approved these changes
Jun 4, 2025
|
One thought - IIRC we got to where we had been because people typod a from address and got upset later that the tool didn't save them from the embarrassment of the mistake. Also while we were pointing at Email, the sending code could note that the address was no longer active and use a better one. These properties are lost, but I believe that sacrifice is what the IAB is asking for at the moment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ietf-tools/liaison-tooling-2025a#4 and #4514
Please review in particular the defaults for the from field in a8fcdc7. I'm especially uncertain about the default for the Liaison Coordinator - maybe it should be the IAB instead of the chair?
FWIW, the migration takes just a few seconds, so no special care is needed. It's not reversible - we could do the reverse lookup, but as soon as someone actually uses an address like chair@ietf.org, there's no going back to a FK to Email, so I don't see a point.