Skip to content

[Imported] system-design-primer #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

[Imported] system-design-primer #255

merged 1 commit into from
Apr 7, 2025

Conversation

ido777
Copy link
Owner

@ido777 ido777 commented Apr 6, 2025

Imported from donnemartin/system-design-primer#1012

Original author: @RathoreAditi


Review the Contributing Guidelines

Before submitting a pull request, verify it meets all requirements in the Contributing Guidelines.

Translations

See the Contributing Guidelines. Verify you've:

  • Tagged the language maintainer
  • Prefixed the title with a language code
    • Example: "ja: Fix ..."

@Copilot Copilot AI review requested due to automatic review settings April 6, 2025 20:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 22 changed files in this pull request and generated no comments.

Files not reviewed (9)
  • B4/Solutions/object_oriented_design/Media_streaming_service/features.text: Language not supported
  • B4/Solutions/object_oriented_design/banking_system/features.text: Language not supported
  • B4/Solutions/object_oriented_design/food_delivery/features.text: Language not supported
  • B4/Solutions/object_oriented_design/hotel_booking/features.text: Language not supported
  • B4/Solutions/object_oriented_design/ride_sharing/features.text: Language not supported
  • B4/Solutions/system_design/Video_conferencing/features.text: Language not supported
  • B4/Solutions/system_design/payment_processing/features.text: Language not supported
  • B4/Solutions/system_design/realtime_collaborative_editing/features.rext: Language not supported
  • B4/Solutions/system_design/smart_home/features.p[y: Language not supported
Comments suppressed due to low confidence (1)

B4/Solutions/object_oriented_design/hotel_booking/hotel.py:47

  • Consider checking if the booking exists in self.customer.bookings before removing it to avoid a potential ValueError on duplicate cancellations.
self.customer.bookings.remove(self)

@ido777 ido777 merged commit 7cf2d80 into main Apr 7, 2025
@ido777 ido777 deleted the imported-pr-1012 branch April 7, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant