IDN events updated #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager events to use Key::Substrate(SubstrateKey::SubscriptionId()) - Removed RandomnessBeacon events as they have no indexable fields - Simplified ChainTrees and ChainKey to only handle basic substrate types - Added comprehensive unit tests for IDN subscription event indexing - Tests cover H256 to u32 conversion, multi-block ordering, and subscription isolation - All tests passing (7/7) including 4 new IDN-specific tests
… function print_runtime_info() from main.rs - Deleted pallets.rs containing Polkadot-specific macros not needed for IDN - Removed debug println from production code in ideal.rs - Cleaned up unused dependencies: serde_json, tracing, hex-literal - All tests still pass (7/7) after cleanup
… component add clippy for nightly toolchain - Resolves GitHub Actions error: cargo-clippy not installed for nightly - CI should now pass clippy checks successfully
juangirini
reviewed
Jun 17, 2025
juangirini
reviewed
Jun 17, 2025
juangirini
approved these changes
Jun 17, 2025
juangirini
left a comment
juangirini
left a comment
There was a problem hiding this comment.
Looks good, I left some minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Key::Substrate(SubstrateKey::SubscriptionId(u32))u32::from_le_bytes([sub_id[0], sub_id[1], sub_id[2], sub_id[3]])ChainTreesto only basic substrate treesChainKeyenum to onlyAccountId,BlockHash,ExtrinsicHash✅ Testing