VB -> C#: Brackets needed around ternary expression #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added unit test to AccessExpressionTest.cs - CommonConversions.cs - use SyntaxFactory.ParenthesizedExpression to ParenthesizedExpression the converted expression if it is a ConditionalExpressionSyntax - Ran all test, no change in existing test, new test passes after initially failing. icsharpcode#1170
|
|
||
| if (convertedExpression is CSSyntax.ConditionalExpressionSyntax ce) { | ||
| convertedExpression = SyntaxFactory.ParenthesizedExpression(convertedExpression); | ||
| } |
There was a problem hiding this comment.
In general the codebase is easier to reason about if you avoid using the shape of the output to influence further output. This is simple enough for now though, so let's go with it!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this covers
#1170
Problem
C# ternary expression do not inherently have a termination, unlike VB ternary. When converted without parameterization, IncreaseArrayUpperBoundExpressionAsync adds 1 to the false result.
Solution