Make use of TARGETARCH and TARGETPLATFORM for better multiarch builds #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That's a thing in Docker? I never knew that, that makes a lot of stuff so much easier for me, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a build arg was used to define the architecture, while there are TARGETARCH and TARGETPLATFORM variables available.
Now you can build multiarch docker images with the same tag, e.g.:
docker buildx build --platform=linux/arm64,linux/amd64 --build-arg version=dev --file Dockerfile.bullseye . --tag dsbaars/lightning-shell:latest --output "type=registry"