Skip to content

Provide new initialization API endpoint (I63) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 9, 2017
Merged

Provide new initialization API endpoint (I63) #64

merged 5 commits into from
Feb 9, 2017

Conversation

ptitzler
Copy link
Contributor

@ptitzler ptitzler commented Feb 8, 2017

Delivers #63:

  • Added new endpoint /initialize in app.js, which initializes the SSS index database (delete database and save new schema)
  • Added new schema definition validation routine validateSchemaDef in lib/schema.js
  • Updated API reference
  • Updated README
  • Increased version number (should this be 0.3.0 since the public API has changed?)
  • No new dependencies

The enhancement should have no impact on existing features.

glynnbird
glynnbird approved these changes Feb 9, 2017
View reviewed changes
Copy link
Contributor

@glynnbird glynnbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @ptitzler. I approve 👍

@glynnbird glynnbird merged commit 2e684b5 into ibm-watson-data-lab:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glynnbird glynnbird glynnbird approved these changes

@MattCollins84 MattCollins84 Awaiting requested review from MattCollins84

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitzler @glynnbird