Skip to content

Fix: Enhance JMS Header Handling for Null Values with proper Kafka Header Mapping #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Joel-hanson
Copy link
Contributor

Description

This pull request introduces enhancements and tests to handle JMS message headers, specifically addressing cases where headers may have null values. It ensures that null properties are correctly processed and optionally copied to Kafka headers based on configuration. The changes include updates to both the main implementation and corresponding test cases.

Enhancements to JMS Header Processing:

New Test Cases for JMS Header Handling:

Minor Code Improvements:

Fixes #145

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Integration tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

balajisekarraman and others added 2 commits June 24, 2025 13:00
…operties, the kafka connect pipeline is failing with NullpointerException while sinking the data to kafka . This scenario is handled in try block in the JmsToKafkaHeaderConverter class
Signed-off-by: Joel Hanson <joelhanson025@gmail.com>
@Joel-hanson Joel-hanson force-pushed the fix-nullpointer-in-copyjmspropstokafkaheaders branch from 103db8d to 6a2066c Compare June 24, 2025 07:32
@Joel-hanson Joel-hanson requested a review from dalelane June 26, 2025 10:18
@Joel-hanson Joel-hanson merged commit 2d832c2 into ibm-messaging:main Jun 27, 2025
2 checks passed
@Joel-hanson Joel-hanson deleted the fix-nullpointer-in-copyjmspropstokafkaheaders branch June 27, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - NullPointerException in Kafka Connect Pipeline when JMS Property Key is Empty
3 participants