mq.receive.max.poll.time.ms, to limit the maximum time spent polling messages in a Kafka Connect task cycle #153
+220
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maximum time (in milliseconds) to spend polling messages before returning a batch to Kafka. Signed-off-by: Joel Hanson <joelhanson025@gmail.com>
Signed-off-by: Joel Hanson <joelhanson025@gmail.com>
Joel-hanson
changed the title
dalelane
approved these changes
Jun 29, 2025
There was a problem hiding this comment.
I've suggested a small refactoring that means we do the sum once up-front, and then just a straight comparison every time around the loop (rather than doing the sum in every loop). In practice, I suspect the performance impact of such a micro-optimisation will be minimal, so feel free to ignore.
Otherwise this all looks good to me, thanks!
| } | ||
|
|
||
| log.debug("Polling for records"); | ||
| final long startTime = System.currentTimeMillis(); |
There was a problem hiding this comment.
Suggested change
| final long startTime = System.currentTimeMillis(); | |
| final long pollEndTime = System.currentTimeMillis() + maxPollTime; |
| message != null && | ||
| localList.size() < numberOfMessagesToBePolled && | ||
| !stopNow.get() && | ||
| (maxPollTime <= 0 || (System.currentTimeMillis() - startTime) < maxPollTime) |
There was a problem hiding this comment.
Suggested change
| (maxPollTime <= 0 || (System.currentTimeMillis() - startTime) < maxPollTime) | |
| (maxPollTime <= 0 || (System.currentTimeMillis() < pollEndTime) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration option,
mq.receive.max.poll.time.ms, to limit the maximum time spent polling messages in a Kafka Connect task cycle. It also includes updates to the implementation and tests to support this feature.New Configuration Option:
mq.receive.max.poll.time.msto define the maximum time (in milliseconds) for polling messages during a Kafka Connect task cycle. If set to0, polling continues until the batch size is met or no more messages are available. This configuration is documented in theREADME.mdand integrated into the connector's configuration definitions.Implementation Updates:
MQSourceTaskclass to use the newmq.receive.max.poll.time.msconfiguration. The polling logic now respects the maximum poll time, ensuring the task terminates polling early if the time limit is reached.Testing Enhancements:
MQSourceTaskIT.javato validate the behavior of themq.receive.max.poll.time.msconfiguration under different scenarios, such as terminating early, respecting batch size, and handling a value of0.These changes improve the flexibility and control of the Kafka Connect source connector for IBM MQ, allowing users to fine-tune message polling behavior.# Description
Type of change
How Has This Been Tested?
Checklist