Added stricter type hints and update PHPUnit test mocks for improved type safety across various classes and test cases. #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
alongosz,
ciastektk,
ViniTou,
barw4 and
wiewiurdp
and removed request for
a team
adamwojs
approved these changes
May 30, 2025
alongosz
reviewed
May 30, 2025
.../AggregationResultExtractor/TermAggregationKeyMapper/ObjectStateAggregationKeyMapperTest.php
Outdated
Show resolved
Hide resolved
…type safety across various classes and test cases.
tbialcz
force-pushed
the
solr-query-wordvisitor-return-types
branch
from
6cbdcd7 to
0386a26
Compare
|
adamwojs
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added native : string return types to visit() and escapeWord() methods in WordVisitor to prevent PHPStan future warning about missing native return type declarations.
Updated UserMetadataAggregationKeyMapperTest to: