Proxy support added for axios. #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have merged the purescript version upgrade. "hopefully you can get it to work." : is it not compiling or crashing ??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for configuring the axios proxy support. I needed proxy support for my purescript client, and this was by far the easier package to add it to. I have a simple
function added to Config.purs. I also have a commented out function that allows passing a URL string, but it depends on Node.URL, so it wouldn't work in a browser. I may try to make it work with purescript-uri if I can figure out how it works.
This patch is mostly based on the "update" pull request I also submitted, but I messed up a bit. The only import diff is for src/Axios/Config.purs, hopefully you can get it to work.