Update pecoff.c to support .gnu_debuglink external files #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pecoff.c (coff_crc32, coff_crc32_file):
Add CRC-32 helpers to verify .gnu_debuglink CRC.
(coff_try_debugfile, coff_find_debugfile_by_debuglink,
coff_open_debugfile_by_debuglink): Add candidate search/open helpers
and validation for external debug files.
(coff_add): Parse .gnu_debuglink and .gnu_debugaltlink, attempt to
open and validate external debug files, recursively parse external
DWARF on success, and fallback to embedded DWARF on failure.
(dll_notification): Fix callback/data usage to avoid crashes when
enumerating/loading DLLs.
MangoFizz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding .gnu_debuglink/.gnu_debugaltlink support to the PE/COFF format lets libbacktrace find and use DWARF stored in a separate file instead of only embedded sections. For MinGW-built binaries this matters because toolchains and packaging often place DWARF in external .debug files (or emit debuglink entries) rather than keeping it in the .exe/.dll.
Changes
pecoff.c