Skip to content

Document inSpan variations #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Document inSpan variations #93

wants to merge 2 commits into from

Conversation

@parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Sep 12, 2023

This PR documents the differences between inSpan, inSpan', and inSpan'', along with callerAttributes, ownCodeAttributes, and exposes srcAttributes for documentation purposes.

@kakkun61
Copy link
Collaborator

kakkun61 commented Sep 20, 2023

It looks nice work! Please format codes with fourmolu 0.13.1.0.

@parsonsmatt
Copy link
Collaborator Author

parsonsmatt commented Sep 20, 2023

I ran make format with fourmolu 0.13.1.0. The diff is pretty big?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkun61 kakkun61 kakkun61 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parsonsmatt @kakkun61