Begin modelling API for metrics #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule as they, and the Meters need to know about each other
velveteer
reviewed
Jun 10, 2025
typo fix Co-authored-by: Josh Miller <notjoshmiller@gmail.com>
velveteer
reviewed
Jul 1, 2025
| = GaugeKind | ||
| | SumKind | ||
| { monotonic :: Monotonicity | ||
| , aggregation :: AggregationTemporality |
There was a problem hiding this comment.
It's generally a bad practice to add field selectors to sum type constructors, and GHC even has a warning for it: https://downloads.haskell.org/ghc/latest/docs/users_guide/using-warnings.html#ghc-flag-Wpartial-fields
I would suggest moving these fields into separate records.
|
This needs documentation, at the very least comments that help me understand how to use these modules. Referencing the OTel spec would be great, but not necessary. |
velveteer
reviewed
Jul 1, 2025
| Version, | ||
| Meter, | ||
| Description, | ||
| UnitOfMeasure, |
There was a problem hiding this comment.
You probably want to export the constructors for most of the types you've defined:
For example:
Suggested change
| UnitOfMeasure, | |
| UnitOfMeasure (..), |
velveteer
reviewed
Jul 2, 2025
|
|
||
| module OpenTelemetry.Metric.Point ( | ||
| GaugePoint, | ||
| SumPoint, |
There was a problem hiding this comment.
Same feedback applies to this module (exports and docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very rudimentary so far. Also currently only int64 values are supported for metrics.