demand-updater #20
Open
demand-updater #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the demand updater based on the paper formulas presented in the open-psi paper. the schema code has some function that were able to be found on MeTTa. In this inplementation all are working as expected |
|
for test to pass I used 0.2 instead of (random-float 0 1). whenever there is 0.2 (random-float 0 1) must be substituted. |
|
The first two test cases are failing due to the psi_utils module not being found. Fix the path properly. |
|
The demand-updater-test.metta is working and it is this file what I made change to .
The test falling for demand-test and feeling updater-test.metta
…On Wed, May 28, 2025, 9:25 AM Samuel Wondimagegnehu < ***@***.***> wrote:
*samwondim* left a comment (iCog-Labs-Dev/hyperon-openpsi#20)
<#20 (comment)>
The first two test cases are failing due to the psi_utils module not being
found. Fix the path properly.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARJFMHEAANT74MNWCNHOO533AVJFXAVCNFSM6AAAAAB5S62RD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJVGEYTSNBTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
samwondim
reviewed
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all demand updaters are working. For testing purpose use replace all random-float with constant number between 0 and 1.