[POC] Add filtering capabilities to SelectNext #1294
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
SelectNext.Filterable
component, designed to wrapSelectNext.Options
objects, and allow them to be filtered via text query.Grabacion.de.pantalla.desde.2023-10-09.11-18-50.webm
Usage
Proposal was described in Part of #1254
TODO
shouldRender
as expected.However, this is not very obvious. There should be a more direct way to call
shouldRender
instead of relying on it being called as a side effect.onFilter
input[type="search"]
. Maybe using a text input with a custom clear button would be an option.Testing steps
This can be tested in http://localhost:4001/input-select-next, with the
Select with filtering
example.