fix(wire/net): remove test backend signature from authMsg of exchange address protocol #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… address protocol Signed-off-by: Minh Huy Tran <huy@perun.network>
NhoxxKienn
force-pushed
the
421_exchange_addrs_auth
branch
from
552c31e to
092ffbb
Compare
Signed-off-by: Minh Huy Tran <huy@perun.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the bug #421 by removing the hard-coded test-backend signature from AuthMsg and required the user to sign all of the address map using all of there backends.
Location
wire/netpackageDisclaimer
This implementation increase the number of authentication msgs by the number of backends (log(n)) and could cause performance issues with a large number of backends.
Signed-off-by: Minh Huy Tran huy@perun.network