Skip to content

Fix the missing url in basic.md #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2025
Merged

Fix the missing url in basic.md #145

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79c881b
Fix the missing url in basic.md
Muffeter Apr 11, 2025
30359ef
Fix the missing url in basic.md
Muffeter Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _stable/client/basic.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ And that's it! You can see the [full example here][example].
[Tokio]: https://tokio.rs
[Tokio-Futures]: https://tokio.rs/tokio/tutorial/async
[StatusCode]: {{ site.hyper_docs_url }}/hyper/struct.StatusCode.html
[Response]: {{ site.hyper_docs_url }}/hyper/struct.Response.html
[Request]: {{ site.hyper_docs_url }}/hyper/struct.Request.html
[Response]: {{ site.http_docs_url }}/http/request/struct.Request.html
[Request]: {{ site.http_docs_urll }}/http/response/index.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these! I noticed the change here has Response pointing at Request, and Request pointing at the response module. The should be swapped, and both link to the respective struct pages. Also, http_docs_urll has two Ls.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I’ll fix the error.

[Connection]: {{ site.hyper_docs_url }}/hyper/client/conn/http1/struct.Connection.html
[SendRequest]: {{ site.hyper_docs_url }}/hyper/client/conn/http1/struct.SendRequest.html
[Frame]: {{ site.hyper_docs_url }}/hyper/body/struct.Frame.html
Expand Down