fix(client): cap pool idle interval to a minimum #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
push-llzunspyvmsp
branch
from
310ba99 to
63872a7
Compare
seanmonstar
force-pushed
the
push-llzunspyvmsp
branch
from
63872a7 to
bf26dd5
Compare
cratelyn
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an incredibly tiny idle timeout, that can cause the idle checker interval to trigger very frequently. It doesn't seem necessary, and so this can cap to a minimum. The connections will still be "expired" at the time the user indicated, and will be respected when
Pool::checkouttries to use it. It just might not be completely reaped from the data structures until a few milliseconds later.@cratelyn any thoughts? I think this is probably a good idea. The amount of time I wasn't too sure on, it's somewhat arbitrary. I figured 100ms, and then made it a little under just in case so nothing waits longer than due to too much load. But I could be convinced of anything.