Skip to content

Conversation

@wrn14897
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2025

🦋 Changeset detected

Latest commit: 3e00bb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/common-utils Patch
@hyperdx/api Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 26, 2025 0:12am

@claude
Copy link

claude bot commented Oct 25, 2025

PR Review: Alert Auto-Resolve + Incident.io Integration

Critical Issues:

  • eventId missing group parameter → The objectHash in template.ts:476-482 doesn't include view.group, causing alerts with different groups (e.g., host=web vs host=api) to share the same deduplication key. This will incorrectly resolve all grouped alerts when one resolves. Add group: view.group to the hash object.

  • ⚠️ Missing URL validation for Incident.iovalidateWebhookUrl in template.ts:109-154 doesn't validate incident.io URLs (only Slack). Add validation to ensure URLs end in incident.io domain to prevent SSRF attacks, similar to Slack validation.

  • ⚠️ Auto-resolve uses empty attributescheckAlerts.ts:391 has attributes: {} with FIXME comment. This means resolved notifications won't include log details. Either implement attribute support or document this limitation.

Minor Issues:

  • AlertInput.id in controllers/alerts.ts:21 is added but never validated or documented. Clarify if this is intentional for future use.

Positive:

  • ✅ Good test coverage updates
  • ✅ Consistent state tracking implementation
  • ✅ Proper error handling for resolve notifications

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2025

E2E Test Results

All tests passed • 25 passed • 3 skipped • 250s

Status Count
✅ Passed 25
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

View full report →

@wrn14897 wrn14897 changed the title feat: add support for alert auto-resolve + Incident.io integration (WIP) feat: add support for alert auto-resolve + Incident.io integration Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant