close modals when bluring (dates and search hints)

[brandon-pereira]

When clicking outside the search hints or date modal, the modals close to prevent them appearing ontop of other modals when you click results

Fixes HDX-2643

[changeset-bot]

🦋 Changeset detected

Latest commit: 81dc266

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@hyperdx/app	Patch
@hyperdx/api	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
hyperdx-v2-oss-app	Ready	Preview	Comment	Oct 24, 2025 9:16am

[knudtty]

add a changeset!

[claude]

Code Review

⚠️ Potential Issue in DBRowTable.tsx

Removing e.stopPropagation() from the row click handler (line 862-863) may cause unintended behavior:

• Problem: The row button contains nested interactive elements (DBRowTableIconButton components in DBRowTableRowButtons and DBRowTableFieldWithPopover) that already handle their own stopPropagation(). However, clicking the row's button will now bubble up and potentially trigger parent handlers.
• Risk: If there are any parent click handlers on the table or other ancestors, they may now be triggered when clicking rows.
• Fix: Test thoroughly to ensure clicking rows doesn't trigger unintended parent click handlers. Consider if this was added to prevent specific bubbling behavior.

✅ TimePicker.tsx change looks good

• Removing closeOnClickOutside={false} allows proper modal closing behavior
• Aligns with standard Mantine Popover patterns used elsewhere in codebase

Testing Recommendation:
Verify that clicking:

1. Row content → opens row details (expected)
2. Copy buttons → only copies, doesn't expand row (should work due to nested stopPropagation)
3. Filter buttons → only filters, doesn't expand row (should work due to nested stopPropagation)
4. Any parent elements → doesn't accidentally expand rows

[github-actions]

E2E Test Results

✅ All tests passed • 26 passed • 3 skipped • 237s

Status	Count
✅ Passed	26
❌ Failed	0
⚠️ Flaky	0
⏭️ Skipped	3

View full report →