Skip to content

Conversation

@knudtty
Copy link
Contributor

@knudtty knudtty commented Oct 23, 2025

Fixes HDX-2644
Fixes #1288

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

🦋 Changeset detected

Latest commit: fd7790f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@knudtty knudtty marked this pull request as ready for review October 23, 2025 21:15
@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 23, 2025 9:22pm

@claude
Copy link

claude bot commented Oct 23, 2025

PR Review

  • Critical: renderRowDetails useCallback missing sourceData dependency (packages/app/src/components/DBSqlRowTableWithSidebar.tsx:84) → Add sourceData to dependency array: }, [sourceData]);

    • This will cause stale closure bug where the callback won't re-render with updated source data
  • ✅ initialSortBy memoization in DBSearchPage.tsx looks correct

  • ✅ Changeset properly documented

Must fix the dependency array before merge.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

E2E Test Results

All tests passed • 25 passed • 3 skipped • 246s

Status Count
✅ Passed 25
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

View full report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance Issue: AutocompleteInput is slow during typing (proposing useCallback refactor)

2 participants