Skip to content

Conversation

@MikeShi42
Copy link
Contributor

image

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

⚠️ No Changeset found

Latest commit: 59d042d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 22, 2025 0:04am

@claude
Copy link

claude bot commented Oct 22, 2025

PR Review

No critical issues found.

The implementation correctly:

  • Adds backend flag exposing ANTHROPIC_API_KEY availability via /api/me endpoint
  • Conditionally renders AI Assistant UI based on the flag
  • Provides dismissible alert with localStorage persistence
  • Restricts AI Assistant to Log/Trace sources only via allowedSourceKinds
  • Follows existing patterns (Mantine UI, optional chaining, localStorage hook)

Minor observation:

  • ℹ️ Label change "Super Experimental" → "Experimental" seems unrelated to main feature (consider separate PR or mention in commit message)

Code quality is solid, follows CLAUDE.md guidelines, and E2E tests pass.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

E2E Test Results

All tests passed • 26 passed • 3 skipped • 242s

Status Count
✅ Passed 26
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

@kodiakhq kodiakhq bot merged commit 5d50e0a into main Oct 22, 2025
8 of 9 checks passed
@kodiakhq kodiakhq bot deleted the mikeshi/dont-always-show-ai-assistant branch October 22, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants