-
Notifications
You must be signed in to change notification settings - Fork 320
refactor(tasks): create subdirectory for alerts code #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The alerts code and some of our private source tasks are becoming complex enough for multiple files. In order to keep the code clearer to debug and read, this commit moves the check alerts tasks into a subdirectory for just alert related code.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: Refactor alerts code into subdirectory✅ No critical issues found. This is a clean refactoring that moves alert-related code into a dedicated subdirectory structure. The changes are well-executed: What was done:
Verified:
Code quality:
|
E2E Test Results✅ All tests passed • 26 passed • 3 skipped • 243s
|
The alerts code and some of our private source tasks are becoming complex enough for multiple files. In order to keep the code clearer to debug and read, this commit moves the check alerts tasks into a sub-directory for just alert related code.