String updates #610
Open
String updates #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify toast strings
Slight rewording and updating copyright date in the license
hushenghao
reviewed
Jul 9, 2025
| @@ -52,12 +52,12 @@ | |||
| <string name="pref_summary_retain_recent_egg_tasks">Retain Easter egg tasks on Recents screen. Up to 5 can be retained. Not available for the activity embedded mode</string> | |||
| <string name="label_about">About</string> | |||
| <string name="label_contribute">Contribute</string> | |||
| <string name="animator_disabled_alert_message">Due to the system animations being disabled, some features may not work properly. Please go to \"Developer options\" and set the \"Animator duration scale\" option to activate the animations</string> | |||
| <string name="action_goto_settings">Go to settings</string> | |||
| <string name="animator_disabled_alert_message">System animations have been disabled. Some functions may not work properly. Please go to Developer options, then change Animator duration scale.</string> | |||
There was a problem hiding this comment.
Please keep their quotation marks, these are the text in the system settings
hushenghao
reviewed
Jul 9, 2025
| @@ -1,4 +1,4 @@ | |||
| # Android Easter Egg | |||
| # Android Easter Eggs | |||
There was a problem hiding this comment.
Easter Egg collection need this plural
hushenghao
reviewed
Jul 9, 2025
| @@ -1,6 +1,6 @@ | |||
| <resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingTranslation"> | |||
| <string name="summary_android_waiting">Currently unavailable</string> | |||
| <string name="summary_android_release_pushed">The final release version has been released</string> | |||
| <string name="summary_android_waiting">Waiting for final release/compilation</string> | |||
There was a problem hiding this comment.
It would be better to modify it to "Waiting for final release"
hushenghao
reviewed
Jul 9, 2025
app/src/main/res/values/strings.xml
Outdated
| @@ -14,7 +14,7 @@ | |||
| <string name="url_telegram_group" translatable="false">https://t.me/+AD_rLq66XERkMDNl</string> | |||
|
|
|||
| <string name="label_version" translatable="false">v%s (%d)</string> | |||
| <string name="toast_no_egg" translatable="false">🤖🚫🥚</string> | |||
| <string name="toast_no_egg" translatable="false">This version doesn't have an Easter egg.</string> | |||
There was a problem hiding this comment.
Isn't this toast too ordinary?
There was a problem hiding this comment.
I changed the toast text because the old one would probably confuse some people
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified toast messages, updated some strings, reworded README. and updated the copyright year