Leader election implementation #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thoven87
commented
May 3, 2025
thoven87
commented
- Leader election implementation
- Right now it's only used to prevent multiple workers (CRON) from enqueuing a job more than once
* Leader election implementation * Right now it's only used to prevent multiple workers (CRON) from enqueuing a job more than once
thoven87
commented
May 3, 2025
adam-fowler
reviewed
May 4, 2025
| @@ -576,6 +611,8 @@ extension PostgresJobQueue { | |||
| if self.queue.isStopped.withLockedValue({ $0 }) { | |||
| return nil | |||
| } | |||
| // The first node to aquire the lock will be the leader | |||
| try await queue.electAsLeader() | |||
There was a problem hiding this comment.
Do we really want to be calling this every time we are popping a job off the queue (something that can be called 100s of times a second), or should we be calling this when a job is ready to schedule.
There was a problem hiding this comment.
Do we really want to be calling this every time we are popping a job off the queue (something that can be called 100s of times a second), or should we be calling this when a job is ready to schedule.
Since we're using the Bully algorithm, we do want to try to elect a leader as fast as possible. Since we only need the election process for just the scheduler as now, it might be worth trying to elect a leader when the scheduler is about to schedule a job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.