Skip to content

Adding Job priority #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 11, 2025
Merged

Adding Job priority #24

merged 9 commits into from
Mar 11, 2025

Conversation

thoven87
Copy link
Contributor

@thoven87 thoven87 commented Mar 6, 2025

  • Job priority
    Need to figure out better ways to test this

adam-fowler
adam-fowler reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

@thoven87 thoven87 marked this pull request as ready for review March 7, 2025 17:18
@thoven87 thoven87 requested a review from Joannis as a code owner March 7, 2025 17:18
adam-fowler
adam-fowler reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks really good. A few minor comments

adam-fowler
adam-fowler approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One additional comment about the enum. If you want the flexibility to possibly extend it later on then you should make it a struct

@thoven87
Copy link
Contributor Author

Looks good. One additional comment about the enum. If you want the flexibility to possibly extend it later on then you should make it a struct

I think it's fine leave JobPriority as public since JobCleanup is already a public enum?

@thoven87 thoven87 requested a review from adam-fowler March 11, 2025 12:17
@thoven87
Copy link
Contributor Author

@adam-fowler you'll have to merge because I don't have permissions to do so.

@adam-fowler
Copy link
Member

@adam-fowler you'll have to merge because I don't have permissions to do so.

try again

@thoven87
Copy link
Contributor Author

@adam-fowler you'll have to merge because I don't have permissions to do so.

try again

Screenshot 2025-03-11 at 8 26 58 AM

Didn't work!

@thoven87 thoven87 merged commit cc39800 into hummingbird-project:main Mar 11, 2025
11 of 12 checks passed
@thoven87
Copy link
Contributor Author

@adam-fowler you'll have to merge because I don't have permissions to do so.

try again

I can't read :( I needed to resolve the comments

@thoven87 thoven87 deleted the job-priority branch March 11, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joannis Joannis Awaiting requested review from Joannis Joannis is a code owner

@adam-fowler adam-fowler Awaiting requested review from adam-fowler adam-fowler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thoven87 @adam-fowler