Skip to content

Decode job straight from row #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 22, 2025
Merged

Decode job straight from row #18

merged 7 commits into from
Feb 22, 2025

Conversation

adam-fowler
Copy link
Member

Instead of decoding as a ByteBuffer and then decoding that ByteBuffer

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 12 lines in your changes missing coverage. Please review.

Project coverage is 89.31%. Comparing base (6d74f49) to head (501da4f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ources/JobsPostgres/AnyDecodableJob+postgres.swift 50.00% 7 Missing ⚠️
Sources/JobsPostgres/PostgresJobsQueue.swift 85.29% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   90.10%   89.31%   -0.80%     
==========================================
  Files           6        8       +2     
  Lines         384      421      +37     
==========================================
+ Hits          346      376      +30     
- Misses         38       45       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from job-driver-parameters to main February 22, 2025 16:03
Copy link
Contributor

@thoven87 thoven87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great already, next I will explore returning the job payload in the same call to dequeue a job to prevent another trip to the database.

@adam-fowler adam-fowler merged commit 59f992e into main Feb 22, 2025
11 of 14 checks passed
@adam-fowler adam-fowler deleted the decode-job-from-row branch February 22, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants