Escrow Cancellation #3357
Open
Escrow Cancellation #3357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
portuu3
requested changes
May 20, 2025
There was a problem hiding this comment.
For bulkPayout we should have the changes from https://github.com/humanprotocol/human-protocol/pull/3261/files. Merge it first
|
For bulkPayout we should have the changes from https://github.com/humanprotocol/human-protocol/pull/3261/files. Merge it first |
* Fix possible no assignments error when there are * Update readme * Update cvat sdk versions * Address api changes * Improve performance of some cvat calls * Improve description
* Draw roi point along with bbox in skeleton tasks * Relax filtering for overlapping gt skeletons (#3358)
flopez7
force-pushed
the
feat/escrow-cancellation
branch
from
3ac3fbb to
3f4dce8
Compare
flopez7
force-pushed
the
feat/escrow-cancellation
branch
from
3f4dce8 to
941d544
Compare
…otocol/human-protocol into feat/escrow-cancellation
* fix payouts when fee calculation is truncated * fix tests and use faker in the root of the repository * document escrow contract and improve tests * Delete unnecessary check for BULK_MAX_VALUE * remove unused modifier * Undo faker package changes for updating yarn --------- Co-authored-by: Francisco López <francislopez977@gmail.com>
portuu3
requested changes
May 21, 2025
…avoid remaining funds and update tests for dynamic amounts
- Updated subgraph package.json to include network-specific test command. - Enhanced GraphQL schema with CancellationRefundEvent and CancellationRequested types. - Implemented event handlers for CancellationRequested and CancellationRefund in EscrowTemplate. - Modified EscrowStatistics to track toCancelStatusEventCount. - Updated dayUpdates utility to initialize dailyToCancelStatusEventCount. - Adjusted template.yaml to listen for CancellationRequested and CancellationRefund events. - Expanded tests to cover new cancellation events and their effects on statistics. - Created fixture functions for generating mock CancellationRequested and CancellationRefund events.
…otocol/human-protocol into feat/escrow-cancellation
flopez7
added
documentation
portuu3
requested changes
Jun 9, 2025
| @@ -486,13 +489,17 @@ def get_w3_with_priv_key(priv_key: str): | |||
| raise EscrowClientError("Invalid empty hash") | |||
| if not validate_url(url): | |||
| raise EscrowClientError(f"Invalid URL: {url}") | |||
| if amount <= 0: | |||
There was a problem hiding this comment.
the contract actually allows amount 0
| @@ -1,6 +1,8 @@ | |||
| export enum EventType { | |||
| ESCROW_COMPLETED = 'escrow_completed', | |||
| ESCROW_CANCELED = 'escrow_canceled', | |||
| eventEntity.txHash = event.transaction.hash; | ||
| eventEntity.escrowAddress = event.address; | ||
| eventEntity.sender = event.transaction.from; | ||
| eventEntity.status = 'Cancelled'; |
There was a problem hiding this comment.
Check internal transaction
|
|
||
| emit IntermediateStorage(_url, _hash); | ||
|
|
||
| if (status == EscrowStatuses.ToCancel) { |
There was a problem hiding this comment.
Cancel the escrow if fundsToReserve=0, unreservedFunds=0 and status is ToCancel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
#3287
Context behind the change
How has this been tested?
Deployed locally and completed the fortune flow with some escrows. Tested normal and cancellation flow
Run unit tests
Release plan
Important: Check that there are no active escrows before deployment to avoid errors due to StoreResult contract change. Also we need to make sure CVAT and Audino are updated to use new contract version
Potential risks; What to monitor; Reverse plan
Since the core has been updated, we have to check each step to make sure it works correctly.