Skip to content

Allow administrator to change the name of the SSO link #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Allow administrator to change the name of the SSO link #47

wants to merge 5 commits into from

Conversation

@andresrs
Copy link

No description provided.

hm-linter[bot]
hm-linter bot suggested changes Aug 23, 2019
View reviewed changes
Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (1 error, 1 warning).

andresrs
andresrs commented Aug 23, 2019
View reviewed changes
Copy link
Author

@andresrs andresrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepared for review.

@andresrs andresrs mentioned this pull request Aug 23, 2019
Open
andresrs
andresrs commented Aug 24, 2019
View reviewed changes
Copy link
Author

@andresrs andresrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review

rmccue
rmccue requested changes Aug 24, 2019
View reviewed changes
Copy link
Member

@rmccue rmccue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We use the wpsimplesaml_log_in_text filter usually, but I'm OK with adding an option for this as well.

@andresrs
Using esc_attr instead of esc_html
2cbfedd 
It's the correct way to handle text attributes.
@andresrs andresrs requested a review from rmccue October 28, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmccue rmccue Awaiting requested review from rmccue

1 more reviewer

@hm-linter hm-linter[bot] hm-linter[bot] requested changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andresrs @rmccue @allysonsouza