Remove default --model-id
argument
#679
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the default value for the
--model-id
in theclap
CLI i.e., the entrypoint for Text Embeddings Inference (TEI), to prevent cases where the model is not captured correctly from e.g. an environment variable, and theBAAI/bge-large-en-v1.5
model is served instead without specific definition from the user, which can be misleading / confusing in some scenarios.Note
Since this PR represents somehow a "breaking change", the PR should be released within a minor version i.e., 1.8.0 if within the next release.
What's missing?
--help
outputs over the documentation and theREADME.md
so that those are consistent with the latest CLI.Before submitting
here are tips on formatting docstrings.
Who can review?
@Narsil