-
Notifications
You must be signed in to change notification settings - Fork 285
Support MRL (Matryoshka Representation Learning) #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the addition! Also I like the macros for Prometheus metrics, those look cleaner IMO.
P.S. Guessing that the snapshots were removed because those were not used, right?
Co-authored-by: Alvaro Bartolome <36760800+alvarobartt@users.noreply.github.com>
oh, sorry for the missing context. you're right! looks like these test cases (router/tests) were all commented, so I've removed the snapshots. updated) thanks for the pointing this :) |
What does this PR do?
Fixes #673
Add
dimensions
field to the embed request API spec.router/tests
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Narsil @alvarobartt